Sylvain Joyeux
2014-09-11 15:27:17 UTC
FYI ... If you wonder why you don't get notifications when a pull request
is updated.
---------- Forwarded message ----------
From: Ivan ?u?ak <support at github.com>
Date: 2014-09-11 12:15 GMT-03:00
Subject: Re: Notification when pull requests are updated
To: Sylvain Joyeux <sylvain.joyeux at m4x.org>
Hey Sylvain,
Yeah, that's normal -- we don't send notifications for push activity in
general, regardless of whether the push updated a pull request or not. It's
something we're already discussing internally, but I can't make any
promises about if/when that might be available.
In the meantime, I can think of two workarounds. First (and this is that
I've seen most GitHub users doing, and we do that internally at GitHub),
after someone pushes more commits to a pull request -- they add a comment
saying "Ready for a new round of reviews!" or something similar. It's often
the case the users push commits before they are ready for a review (e.g.
they push commits over a period of a few days before they are done), so
this allows them to notify the team once they're sure they're done.
If you want to track each push, you could set up webhooks on repositories
you own and subscribe for pull_request events:
https://developer.github.com/webhooks/#events
The "synchronize" action is triggered when a pull request is updated after
the head branch of the pull request is updated. That way, you would get
notified every time a pull request updates, and you could pass that
notification to the reviewer.
Thanks for the feedback and let us know if you have any other questions.
Cheers,
Ivan
way to enable it (could not find anything in the notification
configuration).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.dfki.de/pipermail/rock-dev/attachments/20140911/1acd0404/attachment-0001.htm
is updated.
---------- Forwarded message ----------
From: Ivan ?u?ak <support at github.com>
Date: 2014-09-11 12:15 GMT-03:00
Subject: Re: Notification when pull requests are updated
To: Sylvain Joyeux <sylvain.joyeux at m4x.org>
Hey Sylvain,
Yeah, that's normal -- we don't send notifications for push activity in
general, regardless of whether the push updated a pull request or not. It's
something we're already discussing internally, but I can't make any
promises about if/when that might be available.
In the meantime, I can think of two workarounds. First (and this is that
I've seen most GitHub users doing, and we do that internally at GitHub),
after someone pushes more commits to a pull request -- they add a comment
saying "Ready for a new round of reviews!" or something similar. It's often
the case the users push commits before they are ready for a review (e.g.
they push commits over a period of a few days before they are done), so
this allows them to notify the team once they're sure they're done.
If you want to track each push, you could set up webhooks on repositories
you own and subscribe for pull_request events:
https://developer.github.com/webhooks/#events
The "synchronize" action is triggered when a pull request is updated after
the head branch of the pull request is updated. That way, you would get
notified every time a pull request updates, and you could pass that
notification to the reviewer.
Thanks for the feedback and let us know if you have any other questions.
Cheers,
Ivan
It is common for the reviewee to push updates to its pull request commit.
However, I do not get notified when it happens. Is that normal ? Is there away to enable it (could not find anything in the notification
configuration).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.dfki.de/pipermail/rock-dev/attachments/20140911/1acd0404/attachment-0001.htm