[Rock-dev] [rock] #314: autoproj_bootstrap: patch mac os

[rock]

#314: autoproj_bootstrap: patch mac os
-----------------------+-----------------------------------
Reporter: anonymous | Owner: rock-dev-mailing-list
Type: defect | Status: new
Priority: major | Milestone:
Component: base | Keywords:
-----------------------+-----------------------------------
patch for rock-robotics.org/autoproj_bootstrap to work on mac os:

20c20
< @macos = RbConfig::CONFIG["host_os"] =~%r!([Dd]arwin)!
---

@macos = RbConfig::CONFIG["host_os"] = ~%r!([Dd]arwin)!

1985c1985
< - rb-rake
---

- rake

[rock]

#314: autoproj_bootstrap: patch mac os
-----------------------+------------------------------------
Reporter: anonymous | Owner: rock-dev-mailing-list
Type: defect | Status: new
Priority: major | Milestone:
Component: base | Resolution:
Keywords: |
-----------------------+------------------------------------

Comment (by sylvain.joyeux):

The first part of the patch is wrong. You convert a regex match into an
assignation (which is always true).

Could you run the following ?

{{{
ruby -e "puts RbConfig::CONFIG['host_os']"
}}}

[rock]

#314: autoproj_bootstrap: patch mac os
-----------------------+------------------------------------
Reporter: anonymous | Owner: rock-dev-mailing-list
Type: defect | Status: new
Priority: major | Milestone:
Component: base | Resolution:
Keywords: |
-----------------------+------------------------------------

Comment (by Alexander.Duda):

This is not correct. diff file.orig file_patchted gives you the printed
output. This means the current code is doing the assignment and the patch
is fixing this. But I must admit the format is horrible.

{{{
--- autoproj_bootstrap_orig 2013-08-12 13:01:35.000000000 +0200
+++ autoproj_bootstrap 2013-08-14 22:21:51.000000000 +0200
@@ -17,7 +17,7 @@
@windows
end

- @macos = RbConfig::CONFIG["host_os"] = ~%r!([Dd]arwin)!
+ @macos = RbConfig::CONFIG["host_os"] =~%r!([Dd]arwin)!
def self.macos?
@macos
end
@@ -1982,7 +1982,7 @@
- rubygems
darwin:
- ruby19
- - rake
+ - rb-rake
default: nonexistent
ruby20: ignore
build-essential:
}}}

{{{
irb(main):001:0> RbConfig::CONFIG['host_os']
=> "darwin12.3.0"
}}}

[rock]

#314: autoproj_bootstrap: patch mac os
-----------------------+------------------------------------
Reporter: anonymous | Owner: rock-dev-mailing-list
Type: defect | Status: closed
Priority: major | Milestone:
Component: base | Resolution: fixed
Keywords: |
-----------------------+------------------------------------
Changes (by sylvain.joyeux):

* status: new => closed
* resolution: => fixed


Comment:

As far as I can tell, the next autoproj version has macos support fixed
(thanks Alex). Closing this