Discussion:
[Rock-dev] graph_slam build fails on ubuntu 12.04: "g2o_solver_eigen" library not available
Steffen Planthaber
2014-05-20 15:07:07 UTC
Permalink
Hi,

The lib is is referenced in the pkgconfig file of g2o (added by patch
remotes/rock/patches/g2o_build4.patch) and so rock tries to link it when
building graph_slam

But the lib is only build by g2o/solvers/CMakeLists.txt, when the eigen
version is higher than 3.1 (12.04 has 3.0).

Is the solver used by graph_slam, of can it be removed from the
pkgconfig file?

Best, Steffen
--
Steffen Planthaber
Weltraumrobotik

Besuchsadresse der Nebengesch?ftstelle:
DFKI GmbH
Robotics Innovation Center
Robert-Hooke-Stra?e 5
28359 Bremen, Germany

Postadresse der Hauptgesch?ftsstelle Standort Bremen:
DFKI GmbH
Robotics Innovation Center
Robert-Hooke-Stra?e 1
28359 Bremen, Germany

Tel.: +49 421 178 45-4125
Zentrale: +49 421 178 45-0
Fax: +49 421 178 45-4150 (Faxe bitte namentlich kennzeichnen)
E-Mail: Steffen.Planthaber at dfki.de

Weitere Informationen: http://www.dfki.de/robotik
-----------------------------------------------------------------------
Deutsches Forschungszentrum fuer Kuenstliche Intelligenz GmbH
Firmensitz: Trippstadter Stra?e 122, D-67663 Kaiserslautern
Geschaeftsfuehrung: Prof. Dr. Dr. h.c. mult. Wolfgang Wahlster
(Vorsitzender) Dr. Walter Olthoff
Vorsitzender des Aufsichtsrats: Prof. Dr. h.c. Hans A. Aukes
Amtsgericht Kaiserslautern, HRB 2313
Sitz der Gesellschaft: Kaiserslautern (HRB 2313)
USt-Id.Nr.: DE 148646973
Steuernummer: 19/673/0060/3
-----------------------------------------------------------------------
Steffen Planthaber
2014-05-20 15:54:11 UTC
Permalink
Hi Sylvain,

I think it wasn't intentional you didn't reply to rock-dev.
If the pkg-config file needs to be fixed, it is by adding it
conditionally (i.e. adding it only if it is not built, and not always)
In general, we should probably push all these patches upstream instead
of virtually forking 3rd party library
Sylvain
Just to be clear: g2o does not provide a .pc file at all, it's already
added by our patch.

Is it possible to select patches from .autobuild files?

Afaik the only way to define patches is in the source.yml, and there
they cannot be OS specific.

I think loosing the ability to use the solver on all Operating Systems,
just because one old LTS has no support for it is a bad option.

I agree a "virtual fork" by patching the CMakeLists.txt files of g2o
itself in order to create a proper .pc file is a bad option, as they
might change and cause trouble when out "old" patches are applied ;-)


Greets,

Steffen
If the pkg-config file needs to be fixed, it is by adding it
conditionally (i.e. adding it only if it is not built, and not always)
In general, we should probably push all these patches upstream instead
of virtually forking 3rd party library
Sylvain
2014-05-20 17:07 GMT+02:00 Steffen Planthaber
Hi,
The lib is is referenced in the pkgconfig file of g2o (added by patch
remotes/rock/patches/g2o_build4.patch) and so rock tries to link it when
building graph_slam
But the lib is only build by g2o/solvers/CMakeLists.txt, when the eigen
version is higher than 3.1 (12.04 has 3.0).
Is the solver used by graph_slam, of can it be removed from the
pkgconfig file?
Best, Steffen
--
Steffen Planthaber
Weltraumrobotik
DFKI GmbH
Robotics Innovation Center
Robert-Hooke-Stra?e 5
28359 Bremen, Germany
DFKI GmbH
Robotics Innovation Center
Robert-Hooke-Stra?e 1
28359 Bremen, Germany
Tel.: +49 421 178 45-4125
Zentrale: +49 421 178 45-0
Fax: +49 421 178 45-4150 (Faxe bitte namentlich kennzeichnen)
E-Mail: Steffen.Planthaber at dfki.de
<mailto:Steffen.Planthaber at dfki.de>
Weitere Informationen: http://www.dfki.de/robotik
-----------------------------------------------------------------------
Deutsches Forschungszentrum fuer Kuenstliche Intelligenz GmbH
Firmensitz: Trippstadter Stra?e 122, D-67663 Kaiserslautern
Geschaeftsfuehrung: Prof. Dr. Dr. h.c. mult. Wolfgang Wahlster
(Vorsitzender) Dr. Walter Olthoff
Vorsitzender des Aufsichtsrats: Prof. Dr. h.c. Hans A. Aukes
Amtsgericht Kaiserslautern, HRB 2313
Sitz der Gesellschaft: Kaiserslautern (HRB 2313)
USt-Id.Nr.: DE 148646973
Steuernummer: 19/673/0060/3
-----------------------------------------------------------------------
_______________________________________________
Rock-dev mailing list
Rock-dev at dfki.de <mailto:Rock-dev at dfki.de>
http://www.dfki.de/mailman/cgi-bin/listinfo/rock-dev
--
Steffen Planthaber
Weltraumrobotik

Besuchsadresse der Nebengesch?ftstelle:
DFKI GmbH
Robotics Innovation Center
Robert-Hooke-Stra?e 5
28359 Bremen, Germany

Postadresse der Hauptgesch?ftsstelle Standort Bremen:
DFKI GmbH
Robotics Innovation Center
Robert-Hooke-Stra?e 1
28359 Bremen, Germany

Tel.: +49 421 178 45-4125
Zentrale: +49 421 178 45-0
Fax: +49 421 178 45-4150 (Faxe bitte namentlich kennzeichnen)
E-Mail: Steffen.Planthaber at dfki.de

Weitere Informationen: http://www.dfki.de/robotik
-----------------------------------------------------------------------
Deutsches Forschungszentrum fuer Kuenstliche Intelligenz GmbH
Firmensitz: Trippstadter Stra?e 122, D-67663 Kaiserslautern
Geschaeftsfuehrung: Prof. Dr. Dr. h.c. mult. Wolfgang Wahlster
(Vorsitzender) Dr. Walter Olthoff
Vorsitzender des Aufsichtsrats: Prof. Dr. h.c. Hans A. Aukes
Amtsgericht Kaiserslautern, HRB 2313
Sitz der Gesellschaft: Kaiserslautern (HRB 2313)
USt-Id.Nr.: DE 148646973
Steuernummer: 19/673/0060/3
-----------------------------------------------------------------------
Sylvain Joyeux
2014-05-20 17:13:49 UTC
Permalink
On Tue, May 20, 2014 at 5:54 PM, Steffen Planthaber <
Post by Steffen Planthaber
I think loosing the ability to use the solver on all Operating Systems,
just because one old LTS has no support for it is a bad option.
I agree a "virtual fork" by patching the CMakeLists.txt files of g2o
itself in order to create a proper .pc file is a bad option, as they
might change and cause trouble when out "old" patches are applied ;-)
You don't understand my point

The proper way would be to patch CMakeLists.txt to provide a proper
pkg-config file *and*, most importantly, to get this patch included
upstream instead of having it sitting in the autoproj configuration.

We *are* forking g2o already as we have to maintain our own pkg-config file
(and do a bad job at it, obviously)

Sylvain
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.dfki.de/pipermail/rock-dev/attachments/20140520/9e405bd5/attachment.htm
Steffen Planthaber
2014-05-21 07:29:01 UTC
Permalink
Post by Sylvain Joyeux
On Tue, May 20, 2014 at 5:54 PM, Steffen Planthaber
I think loosing the ability to use the solver on all Operating Systems,
just because one old LTS has no support for it is a bad option.
I agree a "virtual fork" by patching the CMakeLists.txt files of g2o
itself in order to create a proper .pc file is a bad option, as they
might change and cause trouble when out "old" patches are applied ;-)
You don't understand my point
I understood the upstream part, but missed the point that we are already
patching the CMakeLists.txt, my bad.
Post by Sylvain Joyeux
The proper way would be to patch CMakeLists.txt to provide a proper
pkg-config file
I updated the patch which adds the .pc file generation and made it look
for the eigen version and place the libs in to the .pc file accordingly.
Post by Sylvain Joyeux
*and*, most importantly, to get this patch included
upstream instead of having it sitting in the autoproj configuration.
That would be great.
Post by Sylvain Joyeux
Sylvain
Steffen
--
Steffen Planthaber
Weltraumrobotik

Besuchsadresse der Nebengesch?ftstelle:
DFKI GmbH
Robotics Innovation Center
Robert-Hooke-Stra?e 5
28359 Bremen, Germany

Postadresse der Hauptgesch?ftsstelle Standort Bremen:
DFKI GmbH
Robotics Innovation Center
Robert-Hooke-Stra?e 1
28359 Bremen, Germany

Tel.: +49 421 178 45-4125
Zentrale: +49 421 178 45-0
Fax: +49 421 178 45-4150 (Faxe bitte namentlich kennzeichnen)
E-Mail: Steffen.Planthaber at dfki.de

Weitere Informationen: http://www.dfki.de/robotik
-----------------------------------------------------------------------
Deutsches Forschungszentrum fuer Kuenstliche Intelligenz GmbH
Firmensitz: Trippstadter Stra?e 122, D-67663 Kaiserslautern
Geschaeftsfuehrung: Prof. Dr. Dr. h.c. mult. Wolfgang Wahlster
(Vorsitzender) Dr. Walter Olthoff
Vorsitzender des Aufsichtsrats: Prof. Dr. h.c. Hans A. Aukes
Amtsgericht Kaiserslautern, HRB 2313
Sitz der Gesellschaft: Kaiserslautern (HRB 2313)
USt-Id.Nr.: DE 148646973
Steuernummer: 19/673/0060/3
-----------------------------------------------------------------------
Loading...