Discussion:
[Rock-dev] Pull request review
Sylvain Joyeux
2014-07-04 08:40:06 UTC
Permalink
I've created some pull requests two-three weeks ago on some of the
rock-core packages:
https://github.com/orgs/rock-core/dashboard/pulls

I would be very glad if someone could have a look and give me a green
light...

Sylvain
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.dfki.de/pipermail/rock-dev/attachments/20140704/1bc8ac0b/attachment.htm
Janosch Machowinski
2014-07-04 09:06:28 UTC
Permalink
The link you provided is not working.
I can't see any pull requests.
Janosch
Post by Sylvain Joyeux
I've created some pull requests two-three weeks ago on some of the
https://github.com/orgs/rock-core/dashboard/pulls
I would be very glad if someone could have a look and give me a green
light...
Sylvain
_______________________________________________
Rock-dev mailing list
Rock-dev at dfki.de
http://www.dfki.de/mailman/cgi-bin/listinfo/rock-dev
--
Dipl. Inf. Janosch Machowinski
SAR- & Sicherheitsrobotik

Universit?t Bremen
FB 3 - Mathematik und Informatik
AG Robotik
Robert-Hooke-Stra?e 1
28359 Bremen, Germany

Zentrale: +49 421 178 45-6611

Besuchsadresse der Nebengesch?ftstelle:
Robert-Hooke-Stra?e 5
28359 Bremen, Germany

Tel.: +49 421 178 45-6614
Empfang: +49 421 178 45-6600
Fax: +49 421 178 45-4150
E-Mail: jmachowinski at informatik.uni-bremen.de

Weitere Informationen: http://www.informatik.uni-bremen.de/robotik

-------------- n?chster Teil --------------
Ein Dateianhang mit HTML-Daten wurde abgetrennt...
URL: http://www.dfki.de/pipermail/rock-dev/attachments/20140704/99bc725c/attachment.htm
Steffen Planthaber
2014-07-04 09:13:32 UTC
Permalink
Hi,

The link is to the dashboard, which is user specific.

So the link goes to the user logged in. So in my case, the link goes to
my dashboard, i guess there are no requests shown, because i am not part
of the organization?

Best, Steffen
Post by Janosch Machowinski
The link you provided is not working.
I can't see any pull requests.
Janosch
Post by Sylvain Joyeux
I've created some pull requests two-three weeks ago on some of the
https://github.com/orgs/rock-core/dashboard/pulls
I would be very glad if someone could have a look and give me a green
light...
Sylvain
_______________________________________________
Rock-dev mailing list
Rock-dev at dfki.de
http://www.dfki.de/mailman/cgi-bin/listinfo/rock-dev
--
Dipl. Inf. Janosch Machowinski
SAR- & Sicherheitsrobotik
Universit?t Bremen
FB 3 - Mathematik und Informatik
AG Robotik
Robert-Hooke-Stra?e 1
28359 Bremen, Germany
Zentrale: +49 421 178 45-6611
Robert-Hooke-Stra?e 5
28359 Bremen, Germany
Tel.: +49 421 178 45-6614
Empfang: +49 421 178 45-6600
Fax: +49 421 178 45-4150
E-Mail:jmachowinski at informatik.uni-bremen.de
Weitere Informationen:http://www.informatik.uni-bremen.de/robotik
_______________________________________________
Rock-dev mailing list
Rock-dev at dfki.de
http://www.dfki.de/mailman/cgi-bin/listinfo/rock-dev
--
Steffen Planthaber
Weltraumrobotik

Besuchsadresse der Nebengesch?ftstelle:
DFKI GmbH
Robotics Innovation Center
Robert-Hooke-Stra?e 5
28359 Bremen, Germany

Postadresse der Hauptgesch?ftsstelle Standort Bremen:
DFKI GmbH
Robotics Innovation Center
Robert-Hooke-Stra?e 1
28359 Bremen, Germany

Tel.: +49 421 178 45-4125
Zentrale: +49 421 178 45-0
Fax: +49 421 178 45-4150 (Faxe bitte namentlich kennzeichnen)
E-Mail: Steffen.Planthaber at dfki.de

Weitere Informationen: http://www.dfki.de/robotik
-----------------------------------------------------------------------
Deutsches Forschungszentrum fuer Kuenstliche Intelligenz GmbH
Firmensitz: Trippstadter Stra?e 122, D-67663 Kaiserslautern
Geschaeftsfuehrung: Prof. Dr. Dr. h.c. mult. Wolfgang Wahlster
(Vorsitzender) Dr. Walter Olthoff
Vorsitzender des Aufsichtsrats: Prof. Dr. h.c. Hans A. Aukes
Amtsgericht Kaiserslautern, HRB 2313
Sitz der Gesellschaft: Kaiserslautern (HRB 2313)
USt-Id.Nr.: DE 148646973
Steuernummer: 19/673/0060/3
-----------------------------------------------------------------------
Sylvain Joyeux
2014-07-04 09:26:44 UTC
Permalink
Post by Steffen Planthaber
The link is to the dashboard, which is user specific.
So the link goes to the user logged in. So in my case, the link goes to
my dashboard, i guess there are no requests shown, because i am not part
of the organization?
Unfortunately, it seems to be the case

We'll have to create a read-only team and add people in it that want to get
involved

@Steffen: I would be interested to test that theory ... I've added you to a
'reviewer' team on rock-core. Can you see the dashboard now ?
@Janosch: you are meant to be in the Core team anyways ... What's your
username ?

Sylvain
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.dfki.de/pipermail/rock-dev/attachments/20140704/69dedf69/attachment-0001.htm
Sylvain Joyeux
2014-07-04 09:06:27 UTC
Permalink
On Fri, Jul 4, 2014 at 10:40 AM, Sylvain Joyeux <bir.sylvain at gmail.com>
Post by Sylvain Joyeux
I've created some pull requests two-three weeks ago on some of the
https://github.com/orgs/rock-core/dashboard/pulls
One other clarification: while only the Core team members can merge the
PRs, *anyone* can review them. First, it is a good way to learn the
codebase and, second, not having the right to push does not mean that you
cannot have good comments.

In other words: feel free ...

Sylvain
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.dfki.de/pipermail/rock-dev/attachments/20140704/bbebfe4c/attachment.htm
Loading...